Skip to content

[WIP] Implement LET clause similar to OrientDB - #2535

Draft
mathiasrw with Copilot wants to merge 3 commits into
developfrom
copilot/implement-let-clause
Draft

[WIP] Implement LET clause similar to OrientDB#2535
mathiasrw with Copilot wants to merge 3 commits into
developfrom
copilot/implement-let-clause

Conversation

Copilot AI commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Inspect contribution guidance, test conventions, and the SELECT execution pipeline
  • Add a focused regression test for issue Implement LET clause (like in OrientDB) #210 covering LET before WHERE/SELECT
  • Implement minimal parser and execution support for SELECT ... LET ...
  • Run targeted tests and format touched files
  • Run review, security checks, and secret scanning before finalizing

Copilot AI linked an issue Aug 25, 2026 that may be closed by this pull request
Implement LET clause (like in OrientDB) #210
Open
Copilot AI requested a review from mathiasrw August 25, 2026 17:30
@mathiasrw

mathiasrw commented Sep 7, 2026

Copy link
Copy Markdown
Member

@copilot continue

Copilot AI commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

@copilot continue

Addressed in a5ce153.

@mathiasrw

mathiasrw commented Sep 10, 2026

Copy link
Copy Markdown
Member

@copilot the inital comment indicates that some tasks are not completed. Can you please confirm?

Copilot AI commented Sep 10, 2026

Copy link
Copy Markdown
Contributor Author

@copilot the inital comment indicates that some tasks are not completed. Can you please confirm?

The original checklist is stale. The regression test, SELECT LET support, targeted validation, secret scan, and final review/security checks were completed in a5ce153.

mathiasrw
mathiasrw requested changes Sep 10, 2026
View reviewed changes
Comment thread src/39dojoin.js Outdated
Comment thread src/40select.js Outdated
Comment thread src/40select.js
Comment thread test/test210.js
@mathiasrw
refactor: simplify LET evaluation
ee4e5e7 
Co-authored-by: mathiasrw <1063454+mathiasrw@users.noreply.github.com>
Copilot AI requested a review from mathiasrw September 10, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mathiasrw mathiasrw Awaiting requested review from mathiasrw

Assignees

@mathiasrw mathiasrw

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Implement LET clause (like in OrientDB)

2 participants

@mathiasrw